Fixes #1755 aucr cmax r not calculated properly #2093
Conversation
|
@Yuri05 can you revuiew this? |
| return schemaItem.ApplicationType == ApplicationTypes.Intravenous || schemaItem.ApplicationType == ApplicationTypes.IntravenousBolus; | ||
| } | ||
|
|
||
| private ApplicationType applicationTypeFor(Simulation simulation, Compound compound) | ||
| { | ||
| var numberOfApplications = schemaItemsFrom(simulation, compound).Count; | ||
| var numberOfApplications = simulation.AllApplicationParametersOrderedByStartTimeFor(compound.Name).Count; |
There was a problem hiding this comment.
This is the only relevant difference, correct?
For a metabolite (which is not administered) number of applications was zero before; now it is number of applications of its parent drug, right?
By the way, I would rename the function AllApplicationParametersOrderedByStartTimeFor to something like AllOrderedApplicationStartTimes.
Because in AllApplicationParameters I would expect also all other application parameters like e.g. DrugMass, InfusionTime etc. (I had to look into the implementation of the function to understand what it does)
There was a problem hiding this comment.
ok but this is in core so not directly relevant to this problem. Please create an issue for this
For a metabolite (which is not administered) number of applications was zero before; now it is number of applications of its parent drug, right?
yes
There was a problem hiding this comment.
Issue created: Open-Systems-Pharmacology/OSPSuite.Core#1494
PR looks good for me
No description provided.